-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrote benchmark tests for the zPages module #1504
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Scaffolded logic for basic benchmark tests * Wrote benchmark tests for TracezSpanBuckets * Updated README with benchmark tests * Changed the wording slightly
* Scaffolded logic for basic benchmark tests * Wrote benchmark tests for TracezSpanBuckets * Updated README with benchmark tests * Changed the wording slightly * Added a set of benchmark tests for TracezDataAggregator * Modified README formatting * Changed benchmark test to negate dead code elimination
williamhu99
requested review from
anuraaga,
arminru,
bogdandrutu,
carlosalberto and
jkwatson
as code owners
August 4, 2020 22:27
williamhu99
requested review from
pavolloffay,
thisthat and
tylerbenson
as code owners
August 4, 2020 22:27
Codecov Report
@@ Coverage Diff @@
## master #1504 +/- ##
=========================================
Coverage 92.33% 92.33%
Complexity 951 951
=========================================
Files 117 117
Lines 3380 3380
Branches 281 281
=========================================
Hits 3121 3121
Misses 172 172
Partials 87 87 Continue to review full report at Codecov.
|
thisthat
reviewed
Aug 5, 2020
anuraaga
reviewed
Aug 5, 2020
...pages/src/jmh/java/io/opentelemetry/sdk/extensions/zpages/TracezDataAggregatorBenchmark.java
Outdated
Show resolved
Hide resolved
...pages/src/jmh/java/io/opentelemetry/sdk/extensions/zpages/TracezDataAggregatorBenchmark.java
Show resolved
Hide resolved
...s/zpages/src/jmh/java/io/opentelemetry/sdk/extensions/zpages/TracezSpanBucketsBenchmark.java
Show resolved
Hide resolved
…DataAggregator benchmark tests
anuraaga
reviewed
Aug 6, 2020
...pages/src/jmh/java/io/opentelemetry/sdk/extensions/zpages/TracezDataAggregatorBenchmark.java
Show resolved
Hide resolved
...pages/src/jmh/java/io/opentelemetry/sdk/extensions/zpages/TracezDataAggregatorBenchmark.java
Outdated
Show resolved
Hide resolved
...pages/src/jmh/java/io/opentelemetry/sdk/extensions/zpages/TracezDataAggregatorBenchmark.java
Outdated
Show resolved
Hide resolved
…ions/zpages/TracezDataAggregatorBenchmark.java Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
jkwatson
approved these changes
Aug 6, 2020
anuraaga
approved these changes
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains
Benchmark Results
Java version:
Hardware Info
TracezSpanBucketsBenchmark
:TracezDataAggregatorBenchmark
: