PR feedback

open-telemetry · Feb 25, 2022 · b3881bf · b3881bf
1 parent 89fded3
commit b3881bf
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/SdkObservableInstrument.java b/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/SdkObservableInstrument.java
@@ -44,11 +44,11 @@ class SdkObservableInstrument<O>
 
   @Override
   public void close() {
-    if (removed.compareAndSet(false, true)) {
-      storages.forEach(storage -> storage.removeCallback(callback));
+    if (!removed.compareAndSet(false, true)) {
+      throttlingLogger.log(
+          Level.WARNING, "Instrument " + instrumentName + " has called close() multiple times.");
       return;
     }
-    throttlingLogger.log(
-        Level.WARNING, "Instrument " + instrumentName + " has called close() multiple times.");
+    storages.forEach(storage -> storage.removeCallback(callback));
   }
 }