Check SpanData.hasEnded in unit test.

open-telemetry · Dec 17, 2019 · 2dd293a · 2dd293a
1 parent 997aaf8
commit 2dd293a
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/sdk/src/test/java/io/opentelemetry/sdk/trace/RecordEventsReadableSpanTest.java b/sdk/src/test/java/io/opentelemetry/sdk/trace/RecordEventsReadableSpanTest.java
@@ -106,7 +106,8 @@ public void nothingChangedAfterEnd() {
         SPAN_NAME,
         startEpochNanos,
         startEpochNanos,
-        Status.OK);
+        Status.OK,
+        /*hasEnded:*/true);
   }
 
   @Test
@@ -139,7 +140,8 @@ public void toSpanData_ActiveSpan() {
           SPAN_NEW_NAME,
           startEpochNanos,
           0,
-          Status.OK);
+          Status.OK,
+          /*hasEnded:*/false);
       assertThat(span.hasEnded()).isFalse();
     } finally {
       span.end();
@@ -170,7 +172,8 @@ public void toSpanData_EndedSpan() {
         SPAN_NEW_NAME,
         startEpochNanos,
         testClock.now(),
-        Status.CANCELLED);
+        Status.CANCELLED,
+        /*hasEnded:*/true);
   }
 
   @Test
@@ -510,7 +513,8 @@ private void verifySpanData(
       String spanName,
       long startEpochNanos,
       long endEpochNanos,
-      Status status) {
+      Status status,
+      boolean hasEnded) {
     assertThat(spanData.getTraceId()).isEqualTo(traceId);
     assertThat(spanData.getSpanId()).isEqualTo(spanId);
     assertThat(spanData.getParentSpanId()).isEqualTo(parentSpanId);
@@ -525,6 +529,7 @@ private void verifySpanData(
     assertThat(spanData.getStartEpochNanos()).isEqualTo(startEpochNanos);
     assertThat(spanData.getEndEpochNanos()).isEqualTo(endEpochNanos);
     assertThat(spanData.getStatus().getCanonicalCode()).isEqualTo(status.getCanonicalCode());
+    assertThat(spanData.getHasEnded()).isEqualTo(hasEnded);
   }
 
   @Test