Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert JMS Groovy tests to Java #9476

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Convert JMS Groovy tests to Java #9476

merged 1 commit into from
Sep 18, 2023

Conversation

LMarkie
Copy link
Contributor

@LMarkie LMarkie commented Sep 15, 2023

Relates to #7195

Using Jms3InstrumentationTest.java as the basis.

  • failing to receive message tests collapsed into one function via EmptyReceiveArgumentsProvider
  • sending a message to #destinationName with explicit destination propagates context is tested in testMessageListener
  • In Jms1's shouldFailWhenSendingReadOnlyMessage test, the consumer.receive method is ran without a span to emphasise the inability to propagate trace context in this scenario.

@LMarkie LMarkie requested a review from a team September 15, 2023 17:06
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 15, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great, thanks!

@mateuszrzeszutek mateuszrzeszutek merged commit 331aa04 into open-telemetry:main Sep 18, 2023
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants