Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the "executor" instrumentation to "executors" to match gradle … #8451

Merged
merged 1 commit into from
May 9, 2023

Conversation

mateuszrzeszutek
Copy link
Member

…module name

Resolves #8446

@mateuszrzeszutek mateuszrzeszutek requested a review from a team May 9, 2023 09:13
@trask trask merged commit 7fb487a into open-telemetry:main May 9, 2023
@hannahchan
Copy link
Contributor

Question: Is there any adverse effects if I set both of these properties to true at the same time?

otel.instrumentation.executor.enabled: true
otel.instrumentation.executors.enabled: true

This is exactly what I've done to transition to the new behaviour.

@trask
Copy link
Member

trask commented May 10, 2023

nope, that should be fine 👍

@mateuszrzeszutek mateuszrzeszutek deleted the rename-executors branch May 10, 2023 05:33
super(
"executors",
// TODO: remove that after release 1.26.0
"executor");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the downsides to keeping both and leaving the old one as "undocumented"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Executor instrumentation suppression key doesn't match module name
5 participants