Allow users to set otel.javaagent.logging in config.properties file
#8381
Conversation
* Will attempt to read `otel.javaagent.logging` value from config.properties if not found in `ConfigPropertiesUtil` * Change access to `EarlyInitAgentConfig` via a new `INSTANCE` constant
| return new EarlyInitAgentConfig(ConfigurationFileLoader.getConfigFileContents()); | ||
| } | ||
| public static final EarlyInitAgentConfig INSTANCE = | ||
| new EarlyInitAgentConfig(ConfigurationFileLoader.getConfigFileContents()); |
There was a problem hiding this comment.
This actually introduces a chicken-and-egg problem: ConfigurationFileLoader uses loggers, and these cannot be used before the logging system is initialized; which means you cannot use EarlyInitAgentConfig before LoggingCustomizer runs, the way the code is shaped right now.
@0x006EA1E5 I'll try to come up with a few ideas on how to refactor or circumvent that, will come back to this PR in a couple days.
|
Hey @0x006EA1E5 , |
looks good, thanks |
Currently the
otel.javaagent.loggingproperty will only be read from env vars / system properties. This change will mean the option can be set in the config.properties fileotel.javaagent.loggingvalue from config.properties if not found inConfigPropertiesUtilEarlyInitAgentConfigvia a newINSTANCEconstant