Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement HttpServerResponseCustomizer support for Grizzly #8263

Merged
merged 2 commits into from
Apr 12, 2023

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Apr 10, 2023

No description provided.

@laurit laurit requested a review from a team April 10, 2023 17:28
@@ -58,6 +58,11 @@ class GrizzlyTest extends HttpServerTest<HttpServer> implements AgentTestTrait {
server.stop()
}

@Override
boolean hasResponseCustomizer(ServerEndpoint endpoint) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like there's a naming conflict here... perhaps this should be renamed to hasResponseMutator at some point?

Copy link
Member

@mateuszrzeszutek mateuszrzeszutek Apr 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should rename the HttpServerResponseCustomizerHolder as well nvm, I did not look at the code 🙈

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tylerbenson I didn't follow, what's the naming conflict? thx

@@ -58,6 +58,11 @@ class GrizzlyTest extends HttpServerTest<HttpServer> implements AgentTestTrait {
server.stop()
}

@Override
boolean hasResponseCustomizer(ServerEndpoint endpoint) {
Copy link
Member

@mateuszrzeszutek mateuszrzeszutek Apr 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should rename the HttpServerResponseCustomizerHolder as well nvm, I did not look at the code 🙈

@laurit laurit merged commit 271c72b into open-telemetry:main Apr 12, 2023
@laurit laurit deleted the grizzly-response-customizer branch April 12, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants