-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass context to content length http metrics meters #7506
Pass context to content length http metrics meters #7506
Conversation
@trask can you check this issue, I was trying to create a custom view using the baggage api to pass additional attributes and discovered the baggage not available in content length metrics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anuragagarwal561994 can you add some verifications to the existing tests?
E.g. like https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation-api-semconv/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/http/HttpServerMetricsTest.java#L94
@mateuszrzeszutek done, I have added a check to check examplar from context. |
@opentelemetrybot spotless |
oh but it doesn't kick off the status checks due to using GITHUB_TOKEN |
@trask is something to be done here from my side? |
nope, thx for the ping, now merged! |
Closes #7505