Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests for mongodb 4.8 #7183

Merged
merged 2 commits into from
Nov 15, 2022
Merged

Fix tests for mongodb 4.8 #7183

merged 2 commits into from
Nov 15, 2022

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Nov 15, 2022

Resolves #7170

@laurit laurit requested a review from a team November 15, 2022 17:04
trask
trask approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx 👍

@trask
Copy link
Member

trask commented Nov 15, 2022

@laurit it looks like mongo 3.1 tests need to be updated also

mateuszrzeszutek
mateuszrzeszutek approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's going to fix today's daily build failures as well 👍

This was linked to issues Nov 15, 2022
Build (daily, --no-build-cache) #233 failed #7168
Closed
Build (daily, --no-build-cache) #233 failed #7181
Closed
Build (daily, --no-build-cache) #233 failed #7182
Closed
@trask trask merged commit 0cb8c75 into open-telemetry:main Nov 15, 2022
@laurit laurit deleted the mongo-4.8 branch July 6, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@laurit @trask @mateuszrzeszutek