Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename kafka propagation setting and clarify behavior #6957

Merged
merged 2 commits into from
Oct 24, 2022
Merged

Rename kafka propagation setting and clarify behavior #6957

merged 2 commits into from
Oct 24, 2022

Conversation

trask
Copy link
Member

@trask trask commented Oct 23, 2022

Rename otel.instrumentation.kafka.client-propagation.enabled to otel.instrumentation.kafka.producer-propagation.enabled and update code so that it only affects producer propagation, and document the original intent of the setting.

@trask trask marked this pull request as ready for review October 23, 2022 23:52
@trask trask requested a review from a team October 23, 2022 23:52
@trask trask merged commit 9317552 into open-telemetry:main Oct 24, 2022
@trask trask deleted the clarify-kafka-propagation-setting branch October 24, 2022 15:49
trask added a commit that referenced this pull request Oct 24, 2022
I suspect that this was added in the original RocketMQ instrumentation
because it existed in the Kafka instrumentation, and not because there
was a need for it(?)

See #6957 for documentation on why it is needed in Kafka
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 31, 2022
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 31, 2022
I suspect that this was added in the original RocketMQ instrumentation
because it existed in the Kafka instrumentation, and not because there
was a need for it(?)

See open-telemetry#6957 for documentation on why it is needed in Kafka
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Dec 4, 2022
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Dec 4, 2022
I suspect that this was added in the original RocketMQ instrumentation
because it existed in the Kafka instrumentation, and not because there
was a need for it(?)

See open-telemetry#6957 for documentation on why it is needed in Kafka
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants