Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update attribute key of rocketmq's message tag #6677

Merged

Conversation

aaron-ai
Copy link
Member

Fixes #6676

@aaron-ai aaron-ai requested a review from a team September 20, 2022 11:18
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx @aaron-ai! left one comment above

@aaron-ai aaron-ai force-pushed the feature/update_attribute_key_for_rocketmq branch from 71a4e10 to 123d662 Compare September 21, 2022 02:38
@aaron-ai
Copy link
Member Author

aaron-ai commented Sep 21, 2022

@trask got it, messaging.rocketmq.tags has been replaced by the constant in SemanticAttributes.

@trask trask merged commit 527bf61 into open-telemetry:main Sep 21, 2022
@trask
Copy link
Member

trask commented Sep 21, 2022

thx @aaron-ai!

LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 23, 2022
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 31, 2022
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update attribute key of rocketmq's message tag
2 participants