Remove external usages of ClassNames (and move it to internal) #6584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
changed the title
.../opentelemetry/javaagent/instrumentation/spring/webflux/server/WebfluxSpanNameExtractor.java
Outdated
Show resolved
Hide resolved
.../main/java/io/opentelemetry/instrumentation/api/instrumenter/code/CodeSpanNameExtractor.java
Show resolved
Hide resolved
laurit
approved these changes
Sep 12, 2022
There was a problem hiding this comment.
Lambdas aren't the only ones with the same issue, see #3813 Maybe we should truncate after $$ as it is commonly used in generated class names? Though probably should not do this for $$anon$ which is used in some scala classes. JDK proxies don't use $$ and would need to be handled separately.
opened #6595 to track this |
mateuszrzeszutek
approved these changes
Sep 13, 2022
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 23, 2022
…telemetry#6584) * Reduce dependency on simpleName * Move ClassNames to internal * Javadoc * Updates * Fix * Spotless * Rename * Add test
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 31, 2022
…telemetry#6584) * Reduce dependency on simpleName * Move ClassNames to internal * Javadoc * Updates * Fix * Spotless * Rename * Add test
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Dec 4, 2022
…telemetry#6584) * Reduce dependency on simpleName * Move ClassNames to internal * Javadoc * Updates * Fix * Spotless * Rename * Add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also resolves #6583