Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npe in apache http client 4.0 instrumentation #4913

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Dec 15, 2021

NPE is logged when running some apache http client 4.0 tests. For example trace request with callback and parent in ApacheClientHostAbsoluteUriRequest.

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how did this ever work?!??

@laurit
Copy link
Contributor Author

laurit commented Dec 15, 2021

how did this ever work?!??

the method with broken instrumentation chains to another execute method that has working instrumentation

@trask trask merged commit 98d3f88 into open-telemetry:main Dec 16, 2021
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
@laurit laurit deleted the apache-http-client-4.0-npe branch July 6, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants