Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out log4j appender #4907

Merged
merged 1 commit into from
Dec 15, 2021
Merged

Split out log4j appender #4907

merged 1 commit into from
Dec 15, 2021

Conversation

trask
Copy link
Member

@trask trask commented Dec 15, 2021

Resolves #4780

dependencies {
compileOnly("io.opentelemetry:opentelemetry-sdk-logs")

library("org.apache.logging.log4j:log4j-core:2.13.2")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As nobody in its right mind is going to use this version of log4j, should we just start with 2.16? :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya, I think this is the only instrumentation that targets a "patch" version too, will do this in follow-up 👍

@@ -3,16 +3,11 @@ plugins {
}

dependencies {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this module include implementation(project("...:log4j-2.13.2:library"))?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this case is a bit odd. the autoconfigure instrumentation doesn't enable the appender (library) instrumentation. another option is to rename library-autoconfigure to library-context-data.... I'll open an issue to discuss and track

@trask trask merged commit b01efec into open-telemetry:main Dec 15, 2021
@trask trask deleted the split-out-log4j-appender branch December 15, 2021 18:02
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split out log4j appender from log4j autoconfigure module
4 participants