Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix muzzle problems happening when netty without SSL is used #4631

Merged

Conversation

mateuszrzeszutek
Copy link
Member

All the SSL classes are located in the netty-handlers package; netty-codec-http doesn't have them. I refactored the SSL instrumentation handler so that it uses reflection instead of referring to SslHandshakeCompletionEvent directly to make netty with just netty-codec-http work.

@mateuszrzeszutek mateuszrzeszutek merged commit 3a229c8 into open-telemetry:main Nov 12, 2021
@mateuszrzeszutek mateuszrzeszutek deleted the netty-ssl-muzzle branch November 12, 2021 08:54
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants