Extract HTTP request/response headers as span attributes #4237
Conversation
mateuszrzeszutek
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
pavolloffay,
trask and
tylerbenson
as code owners
...rc/main/java/io/opentelemetry/instrumentation/api/instrumenter/http/CapturedHttpHeaders.java
Show resolved
Hide resolved
...va/io/opentelemetry/instrumentation/api/instrumenter/http/HttpCommonAttributesExtractor.java
Show resolved
Hide resolved
| CLIENT = | ||
| CapturedHttpHeaders.create( | ||
| config.getList( | ||
| "otel.instrumentation.common.experimental.capture-http-headers.client.request"), |
There was a problem hiding this comment.
Shouldn't this part of ExperimentalConfig?
There was a problem hiding this comment.
Hmm, you're right. Do you mind if I do that in a separate PR, after this one an #4255 are both merged? I'll just add another item to the TODO list in the PR description (and create a tracking issue for all of them once this PR is merged)
mateuszrzeszutek
force-pushed
the
http-headers
branch
from
9b73886
to
d416ad6
Compare
| private static final Cache<String, AttributeKey<List<String>>> requestKeysCache = | ||
| Cache.newBuilder().setMaximumSize(32).build(); | ||
| private static final Cache<String, AttributeKey<List<String>>> responseKeysCache = | ||
| Cache.newBuilder().setMaximumSize(32).build(); | ||
|
|
There was a problem hiding this comment.
would it work to store the attribute name along with the header name in the configuration object, and avoid the need for this cache?
There was a problem hiding this comment.
We'd create different AttributeKey values for same headers, if there were more than 1 instrumentations (that use them) loaded.
And I wanted to avoid exposing the attribute keys in any public APIs (although now that I think of it, it could be implemented without doing so)
...gent/instrumentation/apachehttpasyncclient/ApacheHttpAsyncClientHttpAttributesExtractor.java
Outdated
Show resolved
Hide resolved
mateuszrzeszutek
force-pushed
the
http-headers
branch
from
ffc9cf9
to
1e81792
Compare
mateuszrzeszutek
force-pushed
the
http-headers
branch
from
f10e161
to
37b7c6c
Compare
This PR implements the HTTP request/response headers as span attributes semantic convention.
It includes:
HttpHeadersConfig)Things that will be done in the followings PRs:
userAgent()andhost()implementations from all instrumentations, they're not needed anymoreHttpClientTestandHttpServerTestServerInstrumentertoHttpServerAttributesExtractorHttpHeadersGetterfor all HTTP instrumentations? since we already have a method that returns values of any header in the extractor (it could implement update Get function in propagators to combine duplicate keys opentelemetry-specification#1884 properly too, for all HTTP instrumentations at the same time)