Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

record exception in dubbo inst #3851

Merged
merged 4 commits into from
Aug 18, 2021

Conversation

tydhot
Copy link
Member

@tydhot tydhot commented Aug 16, 2021

No description provided.

@@ -46,6 +46,9 @@ public Context startClientSpan(String interfaceName, String methodName) {
}

public void end(Context context, Result result) {
if (result.hasException()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you do this, then you don't need to handle span status below.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes i got it:)

@tydhot
Copy link
Member Author

tydhot commented Aug 18, 2021

@iNikem @mateuszrzeszutek hi, it seemed that there is a windows smoke test failed. I have no idea about this, what should I do to fix it?

@mateuszrzeszutek
Copy link
Member

Looks like a random failure - I reran all checks, hope they pass this time.

@tydhot
Copy link
Member Author

tydhot commented Aug 18, 2021

@mateuszrzeszutek thanks!

@mateuszrzeszutek mateuszrzeszutek merged commit 60424e0 into open-telemetry:main Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants