Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'trace_flags' to logging MDC #2312

Merged
merged 2 commits into from
Feb 18, 2021
Merged

Add 'trace_flags' to logging MDC #2312

merged 2 commits into from
Feb 18, 2021

Conversation

mateuszrzeszutek
Copy link
Member

Resolves #2304

  • Remove 'sampled' flag
  • Rename MDC keys to the current logging spec convention: trace_id instead of traceId

I'll update the logging doc after release.

Add 'trace_flags' to logging MDC
7e1d2c1 
* Remove 'sampled' flag
* Rename MDC keys to the current logging spec convention: trace_id instead of traceId
mateuszrzeszutek pushed a commit to mateuszrzeszutek/opentelemetry-java-instrumentation that referenced this pull request Feb 17, 2021
Update logger MDC docs (after open-telemetry#2312)
56e3cfe
mateuszrzeszutek pushed a commit to mateuszrzeszutek/opentelemetry-java-instrumentation that referenced this pull request Feb 17, 2021
Update smoke tests for logging changes (open-telemetry#2312)
9c4ed96
@mateuszrzeszutek mateuszrzeszutek mentioned this pull request Feb 17, 2021
Merged
anuraaga pushed a commit that referenced this pull request Feb 18, 2021
Update smoke tests for logging changes (#2312) (#2316)
15a9d0f
trask
trask approved these changes Feb 18, 2021
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this change, or with the existing java-style MDC property names (traceId, spanId, traceFlags).

@mateuszrzeszutek
Copy link
Member Author

I'm good with this change, or with the existing java-style MDC property names (traceId, spanId, traceFlags).

Some more explanation for my changes: I think that trace_id is a bit more consistent, we use the same name everywhere - and if somebody chooses to log the whole MDC (just use %X pattern) they'll get something like trace_id=12313445 ... by default.

@anuraaga anuraaga merged commit f127a97 into open-telemetry:main Feb 18, 2021
@mateuszrzeszutek mateuszrzeszutek deleted the use-trace-flags-in-logs branch February 18, 2021 08:14
trask pushed a commit that referenced this pull request Feb 21, 2021
Update logger MDC docs (after #2312) (#2313)
efa99f0
@kazuki43zoo
Copy link

Oh... this change broken compatibility with json layout provided by spring-cloud-gcp-logging... Unfortunately...

https://github.com/GoogleCloudPlatform/spring-cloud-gcp/blob/552f227d6b508a4af54166934f176c6fc38ea3f8/spring-cloud-gcp-logging/src/main/java/com/google/cloud/spring/logging/StackdriverTraceConstants.java#L57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuraaga anuraaga anuraaga approved these changes

@trask trask trask approved these changes

@iNikem iNikem iNikem approved these changes

@jkwatson jkwatson Awaiting requested review from jkwatson

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add traceFlags to logging MDC instead of sampled boolean
5 participants
@mateuszrzeszutek @kazuki43zoo @anuraaga @trask @iNikem