remove duplication in tomcat JMX config #12172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
approved these changes
Sep 4, 2024
heyams
approved these changes
Sep 10, 2024
|
cc @PeterF778 in case you have a chance to review |
PeterF778
reviewed
Sep 12, 2024
instrumentation/jmx-metrics/javaagent/src/main/resources/jmx/rules/tomcat.yaml
Outdated
Show resolved
Hide resolved
…nstrumentation into tomcat-jmx-yaml
|
Looks good to me. |
PeterF778
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The YAML configuration allows to use multiple MBeans definitions at once, which allows to avoid duplication when querying MBeans that have the same "shape" and for which the MBeans attributes to query are the same.
Here is an existing example for Kafka.
This allows to elegantly remove the duplication introduced in #10115 for Tomcat that can be exposed with either
Catalina:orTomcat:as JMX domain.