Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instrumentation for graphql 20 that does not use deprecated methods #10779

Merged
merged 4 commits into from
Mar 12, 2024

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Mar 8, 2024

Resolves #10751
Next version of graphql-java will remove the deprecated methods that our instrumentation uses. This PR introduces instrumentation for graphql-java 20.0 that replaces the usage of deprecated apsi with new apis. Hopefully this new instrumentation will also work for the next graphql-java version. This PR also fixes the latest dep tests for graphql-java to use the actual latest version.

@github-actions github-actions bot requested a review from theletterf March 8, 2024 08:31
@laurit laurit marked this pull request as ready for review March 8, 2024 11:28
@laurit laurit requested a review from a team March 8, 2024 11:28
library("com.graphql-java:graphql-java:12.0")
implementation(project(":instrumentation:graphql-java:graphql-java-common:library"))

testImplementation(project(":instrumentation:graphql-java:graphql-java-common:testing"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need latestDepTestLibrary, or that is not needed until next graphql release when the deprecated methods are removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add it. Yes, currently it isn't needed because the tests pass with the latest version. I think this is the first time we have tried to fix the instrumentation before it actually breaks.

@laurit laurit merged commit a3a5725 into open-telemetry:main Mar 12, 2024
49 checks passed
@laurit laurit deleted the graphql-next branch March 12, 2024 11:48
laurit added a commit to laurit/opentelemetry-java-instrumentation that referenced this pull request Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The graphql-java instrumentation is going to break in the next graphl-java release
2 participants