-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't capture http.scheme, http.host and http.target if already capturing http.url #3700
Comments
I guess my #3699 (comment) applies here too. I think we would want to make a call on if the performance matters at all, and if not then we should just remove one of those two versions from the |
https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/docs/semantic-conventions.md#http-server claims that we don't set them :) And explains why :) |
Yeah but it seems to be not really enforced, just an end result? I think of a few options
|
oops 😂 |
http.scheme
,http.host
andhttp.target
are redundant if already capturinghttp.url
.While more telemetry is good, this redundancy doesn't seem worth the (small) additional performance and storage costs.
The text was updated successfully, but these errors were encountered: