-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(collector): enable thrift-compact ports by default #97
feat(collector): enable thrift-compact ports by default #97
Conversation
Hey @secustor, thank you for fixing it! Can you please keep only OTLP fix in this PR and bump version to About thrift compact. It doesn't seem to be a popular format. To be honest I'm not convinced that we should add it by default. Do you use it yourself? |
@dmitryax I have made a break out PR for the endpoint fixes. Regarding thrift compact. This is the protocol which Jaeger instrumentations use to communicate with their node agent. That way their integrations simply "work" instead of looking up the implementation details of the collector and jaeger |
@secustor Ok, sounds good. Let's add it by default. Could you please update this PR? |
This PR: