Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(collector): enable thrift-compact ports by default #97

Merged
merged 8 commits into from
Nov 11, 2021

Conversation

secustor
Copy link
Member

@secustor secustor commented Nov 8, 2021

This PR:

  • enables Jaeger compact thrift protocol to serve as drop in replacement for the Jaeger Agent

@secustor secustor requested review from a team November 8, 2021 08:13
@dmitryax
Copy link
Member

dmitryax commented Nov 10, 2021

Hey @secustor, thank you for fixing it! Can you please keep only OTLP fix in this PR and bump version to 0.7.2 to keep atomic updates?

About thrift compact. It doesn't seem to be a popular format. To be honest I'm not convinced that we should add it by default. Do you use it yourself?

@secustor
Copy link
Member Author

@dmitryax I have made a break out PR for the endpoint fixes.

Regarding thrift compact. This is the protocol which Jaeger instrumentations use to communicate with their node agent.
As Jaeger is deprecating their own Agent in favor of the OTL Collector it makes sense IMO to enable this by default, to give such user a better migration experience. https://www.jaegertracing.io/docs/1.27/deployment/#agent

That way their integrations simply "work" instead of looking up the implementation details of the collector and jaeger

@dmitryax
Copy link
Member

@secustor Ok, sounds good. Let's add it by default. Could you please update this PR?

@secustor secustor changed the title feat(collector): add additional ports and explicitly define OTLP endpoints feat(collector): enable thrift-compact ports by default Nov 10, 2021
@dmitryax dmitryax merged commit 1b90b45 into open-telemetry:main Nov 11, 2021
@secustor secustor deleted the implement-additional-ports branch August 2, 2022 17:45
matej-g pushed a commit to matej-g/opentelemetry-helm-charts that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants