[demo] prometheus honor_labels support #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
dmitryax
approved these changes
Mar 2, 2023
TylerHelmuth
reviewed
Mar 2, 2023
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
TylerHelmuth
approved these changes
Mar 2, 2023
moh-osman3
pushed a commit
to moh-osman3/opentelemetry-helm-charts
that referenced
this pull request
Apr 12, 2023
* prometheus honor_labels Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * bump chart version Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * bump chart version Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com> Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds proper support for
honor_labelswith Prometheus scaped metrics, so thejoblabel will be set properly to the service the metric belongs to. See this PR in the demo repo.