feat(opentelemetry-operator): Adding extraEnv #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiri Tyr <jiri.tyr@gmail.com>
|
We use |
Signed-off-by: Jiri Tyr <jiri.tyr@gmail.com>
jaronoff97
reviewed
Dec 12, 2024
| @@ -1,6 +1,6 @@ | |||
| apiVersion: v2 | |||
| name: opentelemetry-operator | |||
| version: 0.75.0 | |||
| version: 0.76.0 | |||
There was a problem hiding this comment.
please bump the patch version, not the minor version. Once you've done that, please run make generate-examples CHARTS=opentelemetry-operator
There was a problem hiding this comment.
@jtyr it looks like there's no patch version bump anymore, can you do that and re-run the make generate when you can please?
|
@jaronoff97 Please could you review this PR? |
Allex1
approved these changes
Dec 23, 2024
jaronoff97
approved these changes
Dec 23, 2024
jaronoff97
reviewed
Dec 23, 2024
| @@ -104,6 +104,14 @@ manager: | |||
| env: | |||
There was a problem hiding this comment.
@jtyr Minor request, can you please update the docstring here and recommend that people use extraEnvs instead of env please?
There was a problem hiding this comment.
I have added a short deprecation notice. Please review it.
* fix: correct typo in comments for k8sobjects receiver in values.yaml * fix: correct typo in comments for k8sobjects receiver in opentelemetry-kube-stack values.yaml * chore: bump version to 0.110.5 in opentelemetry-collector Chart.yaml * chore: bump version to 0.3.5 in opentelemetry-kube-stack Chart.yaml * Update examples in opentelemetry-collector-0.110.5 * Update examples in opentelemetry-kube-stack-0.3.5 * opentelemetry-collector: bump version to 0.110.6 and update examples * opentelemetry-kube-stack: bump version to 0.3.6 and update examples --------- Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
…metry#1456) Bumps [kyverno/action-install-chainsaw](https://github.com/kyverno/action-install-chainsaw) from 0.2.11 to 0.2.12. - [Release notes](https://github.com/kyverno/action-install-chainsaw/releases) - [Commits](kyverno/action-install-chainsaw@v0.2.11...v0.2.12) --- updated-dependencies: - dependency-name: kyverno/action-install-chainsaw dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Jiri Tyr <jiri.tyr@gmail.com>
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
open-telemetry#1455) * [opentelemetry-kube-stack] Add the helper for servicemonitor.scrapeLimits * naming * version bump, make gen
…ided (open-telemetry#1461) * Create app version helper * Fix description * Bump version --------- Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
Signed-off-by: Jiri Tyr <jiri.tyr@gmail.com>
jtyr
force-pushed
the
jtyr-otelop-env
branch
from
af54bbf to
2b04f0b
Compare
jtyr
requested review from
puckpuck,
dmitryax,
TylerHelmuth and
povilasv
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding the possibility to specify extra environment variable definitions that are not simple name/value pairs, for example when
valueFromshould be used.