Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[demo] - release 1.8.0 #1026

Merged
merged 9 commits into from
Feb 20, 2024
Merged

Conversation

puckpuck
Copy link
Contributor

@puckpuck puckpuck commented Feb 2, 2024

This release adds a new subchart: OpenSearch.

The demo has added Logs support, and it was decided to use OpenSearch for the logging backend. This sets up a single-node OpenSearch cluster as part of the helm chart.

I have a concern that the OpenSearch chart doesn't use the Helm Chart Release name for the service and pod names, nor does it allow us to template inline variables as part of the nameOverride or fullnameOverride properties. As such, we end up with a hardcoded prefix of otel-demo for the OpenSearch pod and service names.

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
# Conflicts:
#	charts/opentelemetry-demo/Chart.yaml
#	charts/opentelemetry-demo/examples/bring-your-own-observability/rendered/component.yaml
#	charts/opentelemetry-demo/examples/bring-your-own-observability/rendered/serviceaccount.yaml
#	charts/opentelemetry-demo/examples/collector-as-daemonset/rendered/component.yaml
#	charts/opentelemetry-demo/examples/collector-as-daemonset/rendered/grafana-dashboards.yaml
#	charts/opentelemetry-demo/examples/collector-as-daemonset/rendered/opentelemetry-collector/daemonset.yaml
#	charts/opentelemetry-demo/examples/collector-as-daemonset/rendered/serviceaccount.yaml
#	charts/opentelemetry-demo/examples/custom-environment-variables/rendered/component.yaml
#	charts/opentelemetry-demo/examples/custom-environment-variables/rendered/grafana-dashboards.yaml
#	charts/opentelemetry-demo/examples/custom-environment-variables/rendered/opentelemetry-collector/deployment.yaml
#	charts/opentelemetry-demo/examples/custom-environment-variables/rendered/serviceaccount.yaml
#	charts/opentelemetry-demo/examples/default/rendered/component.yaml
#	charts/opentelemetry-demo/examples/default/rendered/grafana-dashboards.yaml
#	charts/opentelemetry-demo/examples/default/rendered/opentelemetry-collector/deployment.yaml
#	charts/opentelemetry-demo/examples/default/rendered/serviceaccount.yaml
#	charts/opentelemetry-demo/examples/kubernetes-infra-monitoring/rendered/component.yaml
#	charts/opentelemetry-demo/examples/kubernetes-infra-monitoring/rendered/grafana-dashboards.yaml
#	charts/opentelemetry-demo/examples/kubernetes-infra-monitoring/rendered/opentelemetry-collector/daemonset.yaml
#	charts/opentelemetry-demo/examples/kubernetes-infra-monitoring/rendered/serviceaccount.yaml
#	charts/opentelemetry-demo/examples/public-hosted-ingress/rendered/component.yaml
#	charts/opentelemetry-demo/examples/public-hosted-ingress/rendered/grafana-dashboards.yaml
#	charts/opentelemetry-demo/examples/public-hosted-ingress/rendered/opentelemetry-collector/deployment.yaml
#	charts/opentelemetry-demo/examples/public-hosted-ingress/rendered/serviceaccount.yaml
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
@puckpuck puckpuck marked this pull request as ready for review February 18, 2024 05:41
@puckpuck puckpuck requested a review from a team February 18, 2024 05:41
# Conflicts:
#	charts/opentelemetry-demo/Chart.yaml
#	charts/opentelemetry-demo/examples/bring-your-own-observability/rendered/component.yaml
#	charts/opentelemetry-demo/examples/bring-your-own-observability/rendered/serviceaccount.yaml
#	charts/opentelemetry-demo/examples/collector-as-daemonset/rendered/component.yaml
#	charts/opentelemetry-demo/examples/collector-as-daemonset/rendered/grafana-dashboards.yaml
#	charts/opentelemetry-demo/examples/collector-as-daemonset/rendered/serviceaccount.yaml
#	charts/opentelemetry-demo/examples/custom-environment-variables/rendered/component.yaml
#	charts/opentelemetry-demo/examples/custom-environment-variables/rendered/grafana-dashboards.yaml
#	charts/opentelemetry-demo/examples/custom-environment-variables/rendered/serviceaccount.yaml
#	charts/opentelemetry-demo/examples/default/rendered/component.yaml
#	charts/opentelemetry-demo/examples/default/rendered/grafana-dashboards.yaml
#	charts/opentelemetry-demo/examples/default/rendered/serviceaccount.yaml
#	charts/opentelemetry-demo/examples/kubernetes-infra-monitoring/rendered/component.yaml
#	charts/opentelemetry-demo/examples/kubernetes-infra-monitoring/rendered/grafana-dashboards.yaml
#	charts/opentelemetry-demo/examples/kubernetes-infra-monitoring/rendered/serviceaccount.yaml
#	charts/opentelemetry-demo/examples/public-hosted-ingress/rendered/component.yaml
#	charts/opentelemetry-demo/examples/public-hosted-ingress/rendered/grafana-dashboards.yaml
#	charts/opentelemetry-demo/examples/public-hosted-ingress/rendered/serviceaccount.yaml
@puckpuck
Copy link
Contributor Author

This one is ready for review.

It also incorporates the changes needed for the currency service, which supersedes #1039

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
@TylerHelmuth TylerHelmuth merged commit f71b264 into open-telemetry:main Feb 20, 2024
3 checks passed
12ushan pushed a commit to giffgaff/opentelemetry-helm-charts that referenced this pull request Jul 22, 2024
* Demo release 1.8.0

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>

* Demo release 1.8.0

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>

* Demo release 1.8.0

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>

* Demo release 1.8.0

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>

* Demo release 1.8.0

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>

* Demo release 1.8.0

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>

---------

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
@puckpuck puckpuck deleted the demo.release-1.8.0 branch December 12, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants