Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename kv.Infer to kv.Any (#969) #972

Merged
merged 1 commit into from
Jul 27, 2020
Merged

Rename kv.Infer to kv.Any (#969) #972

merged 1 commit into from
Jul 27, 2020

Conversation

u5surf
Copy link
Contributor

@u5surf u5surf commented Jul 25, 2020 •
edited by MrAlias
Loading

  • Consider renaming Infer to Any. Any is a commonly used concept in Go.

Resolves #969

MrAlias
MrAlias approved these changes Jul 25, 2020
View reviewed changes
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Can you add the change to the Changelog?

@MrAlias MrAlias linked an issue Jul 25, 2020 that may be closed by this pull request
Rename kv.Infer to kv.Any #969
Closed
@u5surf
Rename kv.Infer to kv.Any (open-telemetry#969)
9a021b7 
* Consider renaming Infer to Any. Any is a commonly used concept in Go.
lizthegrey
lizthegrey approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@lizthegrey lizthegrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to leave an alias in place, or do we feel comfortable breaking the API?

@MrAlias
Copy link
Contributor

MrAlias commented Jul 27, 2020

Do we want to leave an alias in place, or do we feel comfortable breaking the API?

For the beta phase we are in I think the the breaking change seems reasonable (especially since the next release will include other breaking changes).

@MrAlias MrAlias merged commit 6917167 into open-telemetry:master Jul 27, 2020
This was referenced Jul 28, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizthegrey lizthegrey lizthegrey approved these changes

@jmacd jmacd jmacd approved these changes

@MrAlias MrAlias MrAlias approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@evantorrie evantorrie Awaiting requested review from evantorrie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename kv.Infer to kv.Any
4 participants
@u5surf @MrAlias @lizthegrey @jmacd