Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify trace and metric stdout exporters #956

Merged
merged 21 commits into from
Jul 22, 2020
Merged

Unify trace and metric stdout exporters #956

merged 21 commits into from
Jul 22, 2020

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jul 22, 2020

  • Unify both exporters into a single Exporter.
  • Create a unified Config that conforms to project patterns.
  • Align output formats.
    • Export spans as lists.
    • Remove outer object wrapper on metric, and export as a list of metrics.
  • Add an overview README in the exporters directory.

Resolves #955

@MrAlias MrAlias self-assigned this Jul 22, 2020
@MrAlias MrAlias mentioned this pull request Jul 22, 2020
Closed
jmacd
jmacd approved these changes Jul 22, 2020
View reviewed changes
exporters/stdout/exporter.go Show resolved Hide resolved
@MrAlias MrAlias merged commit 452256c into open-telemetry:master Jul 22, 2020
@MrAlias MrAlias deleted the stdout-unify branch July 22, 2020 19:34
This was referenced Jul 28, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizthegrey lizthegrey lizthegrey approved these changes

@jmacd jmacd jmacd approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@evantorrie evantorrie Awaiting requested review from evantorrie

@paivagustavo paivagustavo Awaiting requested review from paivagustavo

Assignees

@MrAlias MrAlias

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unify metric and trace the STDOUT exporters
3 participants
@MrAlias @lizthegrey @jmacd