Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

supports marshaling values as json #948

Merged
merged 3 commits into from
Jul 17, 2020
Merged

supports marshaling values as json #948

merged 3 commits into from
Jul 17, 2020

Conversation

lizthegrey
Copy link
Member

@lizthegrey lizthegrey commented Jul 17, 2020 •
edited
Loading

Fixes #947, which @toshok encountered when instrumenting Honeycomb

MrAlias
MrAlias approved these changes Jul 17, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@lizthegrey lizthegrey merged commit b2b23e1 into open-telemetry:master Jul 17, 2020
@lizthegrey lizthegrey deleted the lizf.marshal branch July 17, 2020 20:10
@MrAlias MrAlias mentioned this pull request Jul 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrAlias MrAlias MrAlias approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@evantorrie evantorrie Awaiting requested review from evantorrie

@jmacd jmacd Awaiting requested review from jmacd

@paivagustavo paivagustavo Awaiting requested review from paivagustavo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kv.Infer() naively converts to String rather than using json Marshaler
2 participants
@lizthegrey @MrAlias