OT resource detector

[YANYZP]

Past PR: #924

[lizthegrey]

Flakes were due to a CircleCI/GitHub outage; in future you can force a rerun from the Checks tab without needing to re-push.

[lizthegrey]

Please make your commit history more readable by using git rebase in future.

[MrAlias]

@YANYZP I don't see significant changes made between this and #924. Recreating PRs is sometimes necessary when there are significant revisions that will fundamentally alter the approach of a PR, but it also means all previous comments and reviews are not immediately associated with the PR. This means any previous issue not resolved in the original PR needs to be recreated in the new PR.

As there are now new requests associated with this PR it seems we are not able to go back to #924. Please do not recreate a PR in the future without significant change to the content.

[MrAlias]

This is getting close. Some restructuring and removal of the multierror package are needed though.

[YANYZP]

1. Used []string to integrate errors; 2) restructured codes; 3) adopted QueryUnescape function to handle values

[YANYZP]

Changed code structures and provided more detailed comments

[lizthegrey]

The changes to go.mod/go.sum seem like they may be spurious. Can you revert them, and then run go mod tidy?

[MrAlias]

Looking good, one follow on from the last review.

@YANYZP have you looked into the question @lizthegrey asked above about resetting the go.sum/go.mod files?

[MrAlias]

@YANYZP can we also update the CHANGELOG with this addition?

[lizthegrey]

Can you please instead describe in less technical language? e.g. "Allows Resources to be detected from environment variables"

[YANYZP]

Sure, will do.