-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow configuring the exemplar filter on the metrics SDK #5850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
requested review from
MrAlias,
XSAM,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
September 27, 2024 20:43
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5850 +/- ##
=====================================
Coverage 84.5% 84.5%
=====================================
Files 272 272
Lines 22824 22840 +16
=====================================
+ Hits 19293 19311 +18
+ Misses 3182 3180 -2
Partials 349 349 |
dashpole
force-pushed
the
exemplar_filter
branch
2 times, most recently
from
September 27, 2024 20:48
76f6c41
to
988e0db
Compare
dashpole
force-pushed
the
exemplar_filter
branch
from
September 30, 2024 20:10
5372e89
to
9e2cbc5
Compare
dmathieu
approved these changes
Oct 1, 2024
dashpole
commented
Oct 3, 2024
dashpole
commented
Oct 3, 2024
MrAlias
reviewed
Oct 3, 2024
Co-authored-by: Damien Mathieu <42@dmathieu.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
dashpole
force-pushed
the
exemplar_filter
branch
from
October 4, 2024 13:56
4d14f29
to
020cf0f
Compare
MrAlias
approved these changes
Oct 4, 2024
@MrAlias lets wait until after the release to merge. I don't like merging public API changes right before a release. |
hanyuancheung
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5249
Spec
https://opentelemetry.io/docs/specs/otel/metrics/sdk/#exemplarfilter
Changes
metric.WithExemplarFilter
as an option for the metrics SDK.OTEL_METRICS_EXEMPLAR_FILTER
to the same location as config handling to make code easier to navigate.dropReservoir can actually be removed, but I plan to do that in a follow-up refactor, since it will be a large diff.