Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk/trace: use slices.Grow() to avoid excessive runtime.growslice() #4818

Merged
merged 18 commits into from
Jan 12, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint
  • Loading branch information
lizthegrey authored Jan 11, 2024

Unverified

This user has not yet uploaded their public signing key.
commit 910f7cc40dd7e099442d8119f20081276afa06bb
1 change: 0 additions & 1 deletion sdk/trace/span_test.go
Original file line number Diff line number Diff line change
@@ -246,7 +246,6 @@ func TestTruncateAttr(t *testing.T) {
}

func BenchmarkRecordingSpanSetAttributes(b *testing.B) {
lizthegrey marked this conversation as resolved.
Show resolved Hide resolved

var attrs []attribute.KeyValue
for i := 0; i < 100; i++ {
attr := attribute.String(fmt.Sprintf("hello.attrib%d", i), fmt.Sprintf("goodbye.attrib%d", i))
Loading