Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log: Add design doc #4809

Merged
merged 90 commits into from
Feb 9, 2024
Merged

log: Add design doc #4809

Show file tree
Hide file tree
Changes from 82 commits
Commits
Show all changes
90 commits
Select commit Hold shift + click to select a range
993ebd8
log: Add design doc
pellared Jan 2, 2024
1f35f95
[chore] Fix lint-markdown target
pellared Jan 2, 2024
524032c
[chore] Remove dead hyperlinks
pellared Jan 2, 2024
f095e0f
[chore] Remove dead hyperlink
pellared Jan 2, 2024
87f03a4
Refine docs
pellared Jan 3, 2024
6d1481c
Fix LoggerProvider snippet
pellared Jan 3, 2024
49826ff
Add hyperlink to prototype
pellared Jan 3, 2024
efe740e
Update log/DESIGN.md
pellared Jan 5, 2024
b7a4302
Merge branch 'main' into logs-bridge-part-1
pellared Jan 8, 2024
4137781
Merge branch 'main' into logs-bridge-part-1
pellared Jan 9, 2024
3113402
Add a reference to the prototype in benchmakrs section
pellared Jan 9, 2024
90b3857
Clarify sync.Pool usage
pellared Jan 9, 2024
cbc3a94
Update log/DESIGN.md
pellared Jan 9, 2024
4588071
log: Add design doc
pellared Jan 2, 2024
ba7bc62
[chore] Fix lint-markdown target
pellared Jan 2, 2024
b9c0fc9
[chore] Remove dead hyperlinks
pellared Jan 2, 2024
8cebce5
[chore] Remove dead hyperlink
pellared Jan 2, 2024
c66a91b
Refine docs
pellared Jan 3, 2024
a37b716
Fix LoggerProvider snippet
pellared Jan 3, 2024
0e82c0f
Add hyperlink to prototype
pellared Jan 3, 2024
8b45561
Update log/DESIGN.md
pellared Jan 5, 2024
621be00
Add a reference to the prototype in benchmakrs section
pellared Jan 9, 2024
2f8c6e4
Clarify sync.Pool usage
pellared Jan 9, 2024
c20bcc2
Update log/DESIGN.md
pellared Jan 9, 2024
2f0c54d
Make design decision more explicit
pellared Jan 9, 2024
c503b48
Attributes are defined as a slice
pellared Jan 9, 2024
57b5bdd
Define SeverityNumber
pellared Jan 9, 2024
61f9683
Define LoggerOptions
pellared Jan 10, 2024
fa72f4c
Define noop package
pellared Jan 10, 2024
e126afa
Define all parameters
pellared Jan 10, 2024
e525210
Clarify Record.Body
pellared Jan 10, 2024
ec43527
Document Record.StructuredBody alternative
pellared Jan 10, 2024
917a9a2
Fix typos
pellared Jan 10, 2024
8a33bb4
Merge branch 'main' into logs-bridge-part-1
pellared Jan 10, 2024
2cd7cae
Fix typo
pellared Jan 10, 2024
20ecb0e
Merge branch 'logs-bridge-part-1' of https://github.com/pellared/open…
pellared Jan 10, 2024
51a9bb7
Apply suggestions from code review
pellared Jan 10, 2024
3f25db7
Clarify trace context correlation
pellared Jan 10, 2024
b7a96bc
Merge branch 'main' into logs-bridge-part-1
pellared Jan 11, 2024
8d0da66
Merge branch 'main' into logs-bridge-part-1
pellared Jan 16, 2024
363accf
Merge branch 'main' into logs-bridge-part-1
pellared Jan 16, 2024
90dfb5e
Reference Displaying Severity recommendation
pellared Jan 16, 2024
0cd0677
Add Severity[Level]1 consts
pellared Jan 17, 2024
955ccb8
Simplify severity const block
pellared Jan 17, 2024
d3c0af9
Merge branch 'main' into logs-bridge-part-1
pellared Jan 18, 2024
35ff8f7
Record attributes based on slog.Record
pellared Jan 18, 2024
68986f6
Rejected proposal: Severity type encapsulating number and text
pellared Jan 18, 2024
33bea2e
Merge branch 'main' into logs-bridge-part-1
pellared Jan 18, 2024
60cb10a
The caller must not subsequently mutate the record passed to Emit
pellared Jan 18, 2024
544b371
Refine implementation requirements
pellared Jan 18, 2024
655a44a
Fix grammar
pellared Jan 18, 2024
23dc70d
Merge branch 'main' into logs-bridge-part-1
pellared Jan 19, 2024
bd23513
Update DESIGN.md
pellared Jan 24, 2024
516bc0c
Update DESIGN.md
pellared Jan 24, 2024
a9aeba4
Update DESIGN.md
pellared Jan 24, 2024
c570d87
Merge branch 'main' into logs-bridge-part-1
pellared Jan 24, 2024
cdb4b30
Fix typo
pellared Jan 24, 2024
1b802bd
Update footnotes
pellared Jan 24, 2024
81f9953
Merge branch 'main' into logs-bridge-part-1
pellared Jan 24, 2024
11ac173
Merge branch 'main' into logs-bridge-part-1
pellared Jan 25, 2024
249ecb6
Pass by value
pellared Jan 26, 2024
499da4e
Record with pointer receivers only
pellared Jan 26, 2024
3b526cc
Fix typo
pellared Jan 26, 2024
16a5fbf
Value has As[Kind] methods
pellared Jan 26, 2024
6a47a3c
On fmt.Stringer
pellared Jan 26, 2024
0556320
Merge branch 'main' into logs-bridge-part-1
pellared Jan 29, 2024
ce4751b
Merge branch 'main' into logs-bridge-part-1
pellared Jan 30, 2024
3744193
Update DESIGN.md
pellared Jan 30, 2024
342ebd8
Update DESIGN.md
pellared Jan 30, 2024
f18ce5c
Update DESIGN.md
pellared Jan 30, 2024
67aa37d
Merge branch 'main' into logs-bridge-part-1
pellared Feb 1, 2024
baaa596
Remove KeyValue.Invalid
pellared Feb 1, 2024
9c513c6
Add comments to value snippet
pellared Feb 1, 2024
9ab4546
Update DESIGN.md
pellared Feb 1, 2024
adaab51
Merge branch 'main' into logs-bridge-part-1
pellared Feb 1, 2024
c6e46ff
Fixes
pellared Feb 2, 2024
3f0f1bf
Rewrite Record.Body as any
pellared Feb 2, 2024
bda50d1
Use any instead of defining Value
pellared Feb 2, 2024
82d506b
Update Record attributes as slice
pellared Feb 2, 2024
98bdf81
Fix typo
pellared Feb 2, 2024
ce1dc3b
application -> bridge implementation
pellared Feb 2, 2024
0a4a05e
Merge branch 'main' into logs-bridge-part-1
pellared Feb 6, 2024
ad00cc8
Remove addressed issues
pellared Feb 7, 2024
16c316e
Add Add XYZ method to Logger rejected proposal
pellared Feb 7, 2024
fe8362c
Remove Record.Clone as it is not necessary
pellared Feb 7, 2024
7571081
Rejected proposal: Rename KeyValue to Attr
pellared Feb 7, 2024
b08fead
Fix typo
pellared Feb 7, 2024
a459c58
Merge branch 'main' into logs-bridge-part-1
pellared Feb 7, 2024
f0b9123
Merge branch 'main' into logs-bridge-part-1
pellared Feb 7, 2024
f72a6ed
Merge branch 'main' into logs-bridge-part-1
pellared Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,4 +315,4 @@ add-tags: | $(MULTIMOD)

.PHONY: lint-markdown
lint-markdown:
docker run -v "$(CURDIR):$(WORKDIR)" docker://avtodev/markdown-lint:v1 -c $(WORKDIR)/.markdownlint.yaml $(WORKDIR)/**/*.md
docker run -v "$(CURDIR):$(WORKDIR)" avtodev/markdown-lint:v1 -c $(WORKDIR)/.markdownlint.yaml $(WORKDIR)/**/*.md
Loading