Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otlptracegrpc otlpmetricgrpc: Remove redundant append of DialOptions #4684

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

pellared
Copy link
Member

Fixes #4665

This does not affect the behavior. Therefore, not adding any changelog entry.

@pellared pellared added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 31, 2023
@pellared pellared marked this pull request as ready for review October 31, 2023 11:06
Copy link
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats actually pretty funny

@pellared pellared merged commit 437bc82 into open-telemetry:main Nov 2, 2023
24 checks passed
@pellared pellared deleted the fix-4665 branch November 2, 2023 06:49
@XSAM XSAM added this to the Old Untracked PRs milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

otlptracegrpc otlpconfig adds DialOptions to DialOptions if has DialOptions
5 participants