-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple otlpmetricgrpc and otlpmetrichttp from otlpmetric #4660
Merged
pellared
merged 4 commits into
open-telemetry:main
from
pellared:fix-otlpmetric-version
Oct 24, 2023
Merged
Decouple otlpmetricgrpc and otlpmetrichttp from otlpmetric #4660
pellared
merged 4 commits into
open-telemetry:main
from
pellared:fix-otlpmetric-version
Oct 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4660 +/- ##
=====================================
Coverage 81.3% 81.4%
=====================================
Files 223 225 +2
Lines 17721 17725 +4
=====================================
+ Hits 14423 14429 +6
+ Misses 2998 2996 -2
Partials 300 300
|
pellared
added
area:metrics
Part of OpenTelemetry Metrics
pkg:exporter:otlp
Related to the OTLP exporter package
labels
Oct 23, 2023
pellared
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
hanyuancheung and
dmathieu
as code owners
October 23, 2023 10:30
dashpole
approved these changes
Oct 23, 2023
MrAlias
approved these changes
Oct 23, 2023
hanyuancheung
approved these changes
Oct 24, 2023
This was referenced Nov 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is the only user-facing API change that it would be good to do before making OTLP metrics exporters stable.