Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bridge/opencensus NewMetricExporter deprecation notice #4470

Merged
merged 4 commits into from
Aug 29, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Aug 28, 2023

NewMetricExporter in go.opentelemetry.io/otel/bridge/opencensus was deprecated in v0.35.0 (#3541). However, the notice did not have a preceding blank line in the documentation. Because of this, the documentation for this package does not correctly render the notice:

20230828_114111

These changes fix that formatting resulting in the following when rendered locally:

image

expanded:

20230828_114314

This will also trigger linters about the deprecation notice.

@MrAlias MrAlias added documentation Provides helpful information pkg:bridges Related to a bridge package labels Aug 28, 2023
@MrAlias MrAlias added the bug Something isn't working label Aug 28, 2023
@MrAlias MrAlias added this to the v1.18.0/v0.41.0 milestone Aug 28, 2023
@MrAlias MrAlias marked this pull request as ready for review August 28, 2023 18:46
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #4470 (517b667) into main (e528731) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4470   +/-   ##
=====================================
  Coverage   81.3%   81.3%           
=====================================
  Files        220     220           
  Lines      17662   17662           
=====================================
+ Hits       14370   14372    +2     
+ Misses      2992    2990    -2     
  Partials     300     300           
Files Changed Coverage
bridge/opencensus/metric.go ø

Copy link
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL

@MrAlias MrAlias merged commit e0a39b8 into open-telemetry:main Aug 29, 2023
26 checks passed
@MrAlias MrAlias deleted the re-dep-oc-NewMetricExporter branch August 29, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Provides helpful information pkg:bridges Related to a bridge package
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants