Switch Stream back to having an AttributeFilter field and add New*Filter functions

[MrAlias]

The existing fix to #4156 (#4288) introduced a change that limited the functionality of the SDK. Specifically it prevents the solution of the type of problems found in #3765. This does the following to address #4156:

• Revert "Replace Stream.AttributeFilter with AllowAttributeKeys (Replace Stream.AttributeFilter with AllowAttributeKeys #4288)"
• Add NewAllowKeysFilter and NewDenyKeysFilter to otel/attribute to provide easy allow-keys and deny-keys filter creation.

[codecov]

Codecov Report

Merging #4444 (1fc005d) into main (f15ae16) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Additional details and impacted files

@@           Coverage Diff           @@
##            main   #4444     +/-   ##
=======================================
- Coverage   78.9%   78.9%   -0.1%     
=======================================
  Files        254     255      +1     
  Lines      20642   20651      +9     
=======================================
+ Hits       16301   16308      +7     
- Misses      3996    3999      +3     
+ Partials     345     344      -1     

Files Changed	Coverage Δ
attribute/set.go	77.7% <ø> (ø)
sdk/metric/instrument.go	93.3% <ø> (+1.2%)	⬆️
attribute/filter.go	100.0% <100.0%> (ø)
sdk/metric/pipeline.go	85.9% <100.0%> (-0.1%)	⬇️
sdk/metric/view.go	100.0% <100.0%> (ø)

... and 1 file with indirect coverage changes

[dashpole]

Have we gotten this OK'd with a TC reviewer as being spec compliant?

[MrAlias]

Have we gotten this OK'd with a TC reviewer as being spec compliant?

Not yet. Still working on it.

[dashpole]

LGTM, as long as it complies with the spec.

[MadVikingGod]

If there is TC sign-off, then I Approve this.

[MrAlias]

It was pointed out by @jack-berg that having a filter function in the stream definition here will be similar to the Java approach: https://github.com/open-telemetry/opentelemetry-java/blob/bebf684436b0f54c0c81b19eba1dd9d12ff37532/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/ViewBuilder.java#L67-L77

There they allow a you to define a generic predicate to decide which attribute keys are retained.

However, that only allows attribute keys to be used as the predicate, not values.

[MrAlias]

After a slack conversation with @jack-berg he pointed out that @reyang, @jsuereth, and @jmacd will have more context here. I have created open-telemetry/opentelemetry-specification#3664 and pinged them in the issue.

[MadVikingGod]

I approve this with the assumption that this is for beta release. The Spec compliance is still in process.

[MrAlias]

SIG meeting notes:

• There seems to be TC approval of this
• This is reverting to what is already released with the addition of the two new filter functions
  • Reverting for the release will align with where we hope to land
  • Reverting for the release will avoid any churn which would happen if we were to revert after the release
  • The addition of the two new filter functions, while an addition to the attribute API, seem useful even if the attribute filter field doesn't go through
• The plan is to wait until tomorrow and then merge this and release if there are no objections between now and then
  • View attribute filtering is not compliant with the specification #4156 will remain open to track any future spec work needed