-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple otlp/otlptrace/internal
from otlp/internal
using gotmpl
#4397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4397 +/- ##
======================================
Coverage 83.5% 83.6%
======================================
Files 184 186 +2
Lines 14448 14629 +181
======================================
+ Hits 12073 12238 +165
- Misses 2145 2157 +12
- Partials 230 234 +4
|
MrAlias
force-pushed
the
gotmpl-otlptrace
branch
from
August 1, 2023 19:27
153ad88
to
b113065
Compare
MrAlias
force-pushed
the
gotmpl-otlptrace
branch
from
August 1, 2023 19:51
596170f
to
215044a
Compare
MrAlias
force-pushed
the
gotmpl-otlptrace
branch
from
August 1, 2023 19:57
215044a
to
6ff1a54
Compare
MrAlias
requested review from
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
August 1, 2023 20:20
dashpole
approved these changes
Aug 1, 2023
pellared
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
otlp
exporters share internal packages across package boundaries. This is something we want to stop doing: #3846. This PR addresses the cross-module internal package use for theotel/exporters/otlp/otlptrace
package (but not its sub-modules).gotmpl
tooling to the projectotel/internal/shared
package to hold all templates rendered by thegotmpl
toolingotel/exporters/otlp/internal/retry
package to the shared templatesotel/exporters/otlp/internal/envconfig
package to the shared templatesotel/exporters/otlp/otlptrace/internal
package to the shared templatesgotmpl
to render the newretry
andenvconfig
packages inotel/exporters/otlp/otlptrace/internal
gotmpl
to render the rest ofotel/exporters/otlp/otlptrace/internal
so it can use the now localretry
andenvconfig
packages.otlptracegrpc
andotlptracehttp
to use theotel/exporters/otlp/otlptrace/internal
packagesWhat is not included
Both the
otlptracegrpc
andotlptracehttp
packages can now also have copies of these (and other) packages. This will decouple both packages from theotlptrace/internal
packages.The plan once this is merged is to tackle each of those packages in their own PRs.
Why not skip
otlptrace/internal
and just do everything inotlptracegrpc/internal
andotlptracehttp/internal
?The
otlptrace/internal
package is planned to be flattened into both. However, for backwards compatibility reasonsotlptrace/internal
cannot be removed even after the sub-modules no longer depend on it.Given
otlptrace/internal
will need to exist in the future until a major version bump, it is updated here to at least not have a cross module internal package dependency (other thanotel/internal/global
).