sdk/metric: Remove Reader.ForceFlush and ManualReader.ForceFlush #4375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pellared
changed the title
pellared
changed the title
pellared
changed the title
pellared
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
hanyuancheung and
dmathieu
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4375 +/- ##
=====================================
Coverage 78.8% 78.8%
=====================================
Files 253 253
Lines 20645 20644 -1
=====================================
+ Hits 16280 16283 +3
+ Misses 4016 4012 -4
Partials 349 349
|
pellared
added
the
blocked:specification
MrAlias
approved these changes
Jul 27, 2023
|
There is no consensus on specification PR, but I looks like all objections are NOT related to changes proposed in this PR. E.g. see: open-telemetry/opentelemetry-specification#3609 (review). Still, I prefer to wait and consider it as blocked. |
pellared
removed
the
blocked:specification
|
Now blocked on open-telemetry/opentelemetry-specification#3563 PS. During the last specification SIG meeting nobody was against this approach. |
hanyuancheung
approved these changes
Aug 4, 2023
pellared
changed the title
|
open-telemetry/opentelemetry-specification#3563 is merged 🎉 |
pellared
commented
Aug 9, 2023
MrAlias
reviewed
Aug 10, 2023
dashpole
approved these changes
Aug 10, 2023
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
pellared
added
pkg:SDK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The
Reader.ForceFlushandManualReader.ForceFlushare not needed and we can remove it to make the user-facing API cleaner. E.g. we do not need the Prometheus exporter to haveForceFlush(via type embedding ofmetric.Reader).ForceFlushis only required when periodic reader is used. This change is now possible after #4244.The OTel Specification does NOT require to require to have
Reader.ForceFlush. For instance the OTel .NET SDK readers do not implementForceFlushat all.Related PRs and issues in specification:
What
Remove
Reader.ForceFlushandManualReader.ForceFlush. Use type assertions so thatForceFlushis properly handled by theMetricProvider.