Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PeriodicReader.Shutdown now applies the periodic reader's timeout by default #4356

Merged
merged 4 commits into from
Jul 25, 2023

Merge branch 'main' into shutdown_timeout

2c41d82
Select commit
Loading
Failed to load commit list.
Merged

PeriodicReader.Shutdown now applies the periodic reader's timeout by default #4356

Merge branch 'main' into shutdown_timeout
2c41d82
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 25, 2023 in 0s

83.4% (-0.1%) compared to d8d3502

View this Pull Request on Codecov

83.4% (-0.1%) compared to d8d3502

Details

Codecov Report

Merging #4356 (2c41d82) into main (d8d3502) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4356     +/-   ##
=======================================
- Coverage   83.4%   83.4%   -0.1%     
=======================================
  Files        184     184             
  Lines      14374   14376      +2     
=======================================
- Hits       12001   11999      -2     
- Misses      2145    2149      +4     
  Partials     228     228             
Files Changed Coverage Δ
sdk/metric/periodic_reader.go 84.1% <100.0%> (+0.1%) ⬆️

... and 2 files with indirect coverage changes