-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for malformed selectors in readers #4350
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4350 +/- ##
=======================================
- Coverage 83.4% 83.4% -0.1%
=======================================
Files 184 184
Lines 14376 14383 +7
=======================================
+ Hits 12003 12006 +3
- Misses 2145 2149 +4
Partials 228 228
|
MadVikingGod
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
pellared,
hanyuancheung and
dmathieu
as code owners
July 21, 2023 20:53
dashpole
approved these changes
Jul 21, 2023
hanyuancheung
approved these changes
Jul 24, 2023
pellared
reviewed
Jul 24, 2023
dmathieu
approved these changes
Jul 24, 2023
MrAlias
reviewed
Jul 24, 2023
pellared
approved these changes
Jul 24, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests for unusual ways that users may configure
Reader
's AggregationSelector and TemporalitySelector.This fixes two errors:
nil
the reader would panic.Resloves #3665