-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add info/debug logging to the metric SDK #4315
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4315 +/- ##
=======================================
- Coverage 83.6% 83.4% -0.2%
=======================================
Files 183 184 +1
Lines 14227 14350 +123
=======================================
+ Hits 11903 11979 +76
- Misses 2098 2145 +47
Partials 226 226
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
Not all logr adapters (zapr or logrusr, I can't remember which) will marshal deeply nested MarshalLog structs or slices of MarshalLog. I think it is fine to avoid working around those implementations.
Resolves #3722
Info log the creation of a
MeterProvider
andMeter
. Debug log the collection from the periodic and manual reader as well as the exports of the Prometheus, stdout, and OTLP exporters. For reference, info/debug logging is not enable by default so this change will not show unless a user enables it.Verification
Manually tested using the following modified version of the
view
example:Got: