Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add otlpmetric Temporality Preference env var #4287

Merged
merged 9 commits into from
Jul 20, 2023

Conversation

MadVikingGod
Copy link
Contributor

This adds the OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE from the spec

@MadVikingGod MadVikingGod added area:metrics Part of OpenTelemetry Metrics pkg:exporter:otlp Related to the OTLP exporter package labels Jul 5, 2023
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #4287 (c02f4f4) into main (e08359f) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4287   +/-   ##
=====================================
  Coverage   83.4%   83.4%           
=====================================
  Files        185     185           
  Lines      14332   14359   +27     
=====================================
+ Hits       11958   11983   +25     
- Misses      2147    2149    +2     
  Partials     227     227           
Impacted Files Coverage Δ
...orters/otlp/otlpmetric/internal/oconf/envconfig.go 92.0% <100.0%> (+2.5%) ⬆️

... and 1 file with indirect coverage changes

@dmathieu
Copy link
Member

dmathieu commented Jul 6, 2023

Should there be tests? (and a changelog)

@MadVikingGod
Copy link
Contributor Author

Comment from other PR: There is a lack of documentation around what Environment variables are supported. Could we create somewhere that users can find OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE?

@MadVikingGod
Copy link
Contributor Author

For the documentation of the EnvVar there is a lack of documentation of the entire package. I created a PR (#4336) that includes Environment variables documentation. @pellared can that satisfy the documentation ask here?

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the documentation of the EnvVar there is a lack of documentation of the entire package. I created a PR (#4336) that includes Environment variables documentation. @pellared can that satisfy the documentation ask here?

Sure 👍

@MadVikingGod MadVikingGod merged commit a5c82bf into open-telemetry:main Jul 20, 2023
21 checks passed
@MadVikingGod MadVikingGod deleted the mvg/low-memory branch July 20, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics pkg:exporter:otlp Related to the OTLP exporter package
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

6 participants