Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use stateful batcher on prometheus exporter #428

Merged
merged 1 commit into from
Jan 11, 2020
Merged

use stateful batcher on prometheus exporter #428

merged 1 commit into from
Jan 11, 2020

Conversation

paivagustavo
Copy link
Member

This rollbacks the change made to the batcher used in the prometheus exporter by mistake on #395.

@paivagustavo paivagustavo added exporters area:metrics Part of OpenTelemetry Metrics labels Jan 11, 2020
@paivagustavo paivagustavo mentioned this pull request Jan 11, 2020
Closed
@lizthegrey lizthegrey merged commit d85178b into open-telemetry:master Jan 11, 2020
@paivagustavo paivagustavo deleted the fix-prometheus-batcher branch January 11, 2020 01:22
@lizthegrey
Copy link
Member

should I cut another release for this @rghetia @jmacd?

@rghetia
Copy link
Contributor

rghetia commented Jan 13, 2020 •
edited
Loading

should I cut another release for this @rghetia @jmacd?

yes.

@lizthegrey
Copy link
Member

lizthegrey commented Jan 13, 2020 •
edited
Loading

v0.2.1.1 cut. No submodule changes made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizthegrey lizthegrey lizthegrey approved these changes

@iredelmeier iredelmeier iredelmeier approved these changes

@jmacd jmacd Awaiting requested review from jmacd

@rghetia rghetia Awaiting requested review from rghetia

@tedsuo tedsuo Awaiting requested review from tedsuo

Assignees
No one assigned
Labels
area:metrics Part of OpenTelemetry Metrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paivagustavo @lizthegrey @rghetia @iredelmeier