Document and test honoring context in metric readers Collect #4267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmathieu
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared and
hanyuancheung
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4267 +/- ##
=====================================
Coverage 83.5% 83.6%
=====================================
Files 181 181
Lines 14162 14162
=====================================
+ Hits 11830 11840 +10
+ Misses 2105 2096 -9
+ Partials 227 226 -1
|
MrAlias
approved these changes
Jun 28, 2023
pellared
approved these changes
Jun 28, 2023
hanyuancheung
approved these changes
Jun 29, 2023
pellared
approved these changes
Jun 29, 2023
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4166.
Readerinterface that every reader has to honor the context's deadlineManualReaderhonors the context's deadline, and test it.PeriodicReaderhonors the context's deadline, and test it.