otlptracegrpc: Fix start/stop sync in mockCollector #3989
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed when looking at #2686
This PR is intended to get rid of
<-time.After(number * time.Millisecond)
and properly synchronize the mock collector startup and shutdown. It should make the tests more stable.For me before this fix running
go test -race -count=100
is almost hanging (240sec for me). After this fix I get:(before this fix the failure is after
241.189s
).So not only it makes the tests more trustworthy (stable) but also shortens the execution time by 10 times (on my PC).