-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the metric Export
interface to accept a *ResourceMetrics
instead of ResourceMetrics
#3853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unicod3
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
March 9, 2023 23:47
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3853 +/- ##
=======================================
- Coverage 81.6% 81.5% -0.1%
=======================================
Files 169 169
Lines 12723 12711 -12
=======================================
- Hits 10383 10371 -12
Misses 2121 2121
Partials 219 219
|
Thanks for the contribution! Please do add a changelog entry for the exported |
unicod3
force-pushed
the
reduce-call-stack-size
branch
from
March 10, 2023 20:10
8ee6dd7
to
d242439
Compare
dubonzi
reviewed
Mar 10, 2023
pellared
reviewed
Mar 13, 2023
exporters/otlp/otlpmetric/internal/transform/metricdata_test.go
Outdated
Show resolved
Hide resolved
pellared
reviewed
Mar 14, 2023
pellared
approved these changes
Mar 14, 2023
dubonzi
approved these changes
Mar 16, 2023
MrAlias
approved these changes
Mar 16, 2023
MrAlias
added
pkg:SDK
Related to an SDK package
area:metrics
Part of OpenTelemetry Metrics
labels
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3852
Hello,
I am not sure if that requires a change log, I can update it if it does.Updated the change log