-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Exemplar
to metricdata package
#3849
Conversation
2e6cf74
to
35ad3cb
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3849 +/- ##
=======================================
- Coverage 81.7% 81.6% -0.2%
=======================================
Files 169 169
Lines 12581 12723 +142
=======================================
+ Hits 10288 10387 +99
- Misses 2078 2117 +39
- Partials 215 219 +4
|
f06d7aa
to
0d2173e
Compare
0d2173e
to
215fdb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General question, just to clarify: do we want to implement "Exemplar" before it is Stable in the specification?
I'm not sure we want to implement it given the unstable nature of the specification around it. That and I think the specification has some evolving to do regarding the exemplar. That said, I do want to make sure we can add support in the future. These changes are necessary now so we don't have to implement something sub-par to support them in the future or introduce backwards incompatible changes later. As pointed out in your other comment, I think there is still some follow-up work to address here.
I think (2) is helpful on the path to supporting exemplars, but not needed for the GA of the specification. |
Part of #3834
Exemplar[N int64 | float64]
struct
tosdk/metric/metricdata
Exemplars []Exemplar[N]
field toDataPoint
insdk/metric/metricdata
Exemplars []Exemplar[N]
field toHistogramDataPoint
insdk/metric/metricdata
HistogramDataPoint
to be defined generically asHistogramDataPoint[N int64 | float64]
Histogram
to be defined generically asHistogram[N int64 | float64]
metricdatatest
to supportExemplar
metricdatatest
to supportHistogramDataPoint[N]
sdk/metric
histogram aggregator to produceHistogram[N]
Histogram[N]
Exemplar
Histogram[N]
(only producedHistogram[float64]
)