Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the deprecated otel/metric/global pkg #3829

Merged
merged 6 commits into from
Mar 7, 2023
Merged

Remove the deprecated otel/metric/global pkg #3829

merged 6 commits into from
Mar 7, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Mar 2, 2023

Resolve #3819

@MrAlias MrAlias added this to the v1.15.0 milestone Mar 2, 2023
@codecov
Copy link

codecov bot commented Mar 2, 2023 •
edited
Loading

Codecov Report

Merging #3829 (af4515a) into main (3015c86) will increase coverage by 0.0%.
The diff coverage is 63.8%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3829   +/-   ##
=====================================
  Coverage   81.7%   81.7%           
=====================================
  Files        170     168    -2     
  Lines      12474   12462   -12     
=====================================
- Hits       10192   10184    -8     
+ Misses      2067    2063    -4     
  Partials     215     215
Impacted Files Coverage Δ
internal/global/instruments.go 60.8% <0.0%> (ø)
internal/global/meter.go 93.8% <0.0%> (ø)
metric.go 66.6% <ø> (ø)
internal/global/state.go 100.0% <100.0%> (ø)

@MrAlias MrAlias marked this pull request as ready for review March 2, 2023 19:31
@MrAlias MrAlias merged commit 60f7d42 into open-telemetry:main Mar 7, 2023
@MrAlias MrAlias deleted the rm-metric-global branch March 7, 2023 16:36
@MrAlias MrAlias modified the milestones: v1.15.0, v1.15.0-RC2 Mar 22, 2023
@MrAlias MrAlias mentioned this pull request Mar 22, 2023
Merged
@mahboubii mahboubii mentioned this pull request Mar 27, 2023
Closed
MrAlias added a commit to MrAlias/opentelemetry-go that referenced this pull request Apr 11, 2023
@MrAlias
Revert "Remove the deprecated otel/metric/global pkg (open-telemetr…
ec31683 
…y#3829)"

This reverts commit 60f7d42.
MrAlias added a commit that referenced this pull request Apr 13, 2023
@MrAlias
Move global metric back to otel/metric/global for minor release (#3986
8dba38e 
)

* Revert "Remove the deprecated `otel/metric/global` pkg (#3829)"

This reverts commit 60f7d42.

* Revert "Support a global MeterProvider in `go.opentelemetry.io/otel` (#3818)"

This reverts commit 8139361.

* Remove top level metric global

* Add change to changelog
@chuliang chuliang mentioned this pull request May 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanyuancheung hanyuancheung hanyuancheung approved these changes

@pellared pellared pellared approved these changes

@MadVikingGod MadVikingGod MadVikingGod approved these changes

@jmacd jmacd Awaiting requested review from jmacd

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@evantorrie evantorrie Awaiting requested review from evantorrie

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@dmathieu dmathieu Awaiting requested review from dmathieu dmathieu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Go: Metric API (GA)
Status: Done
Milestone
v1.15.0-RC2
Development

Successfully merging this pull request may close these issues.

Remove the deprecated otel/metric/global package
4 participants
@MrAlias @MadVikingGod @pellared @hanyuancheung