Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the unused produceKey and callbackKey #3602

Merged
merged 2 commits into from
Jan 20, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jan 19, 2023

Cleanup following #3584, this value and type are no longer used.

Following open-telemetry#3584, this value and type are no longer used.
@MrAlias MrAlias added this to the Metric v0.35.0 milestone Jan 19, 2023
@MrAlias MrAlias added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 19, 2023
@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #3602 (0ed2096) into main (b1a8002) will decrease coverage by 0.1%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3602     +/-   ##
=======================================
- Coverage   79.0%   79.0%   -0.1%     
=======================================
  Files        170     170             
  Lines      12587   12585      -2     
=======================================
- Hits        9952    9950      -2     
  Misses      2422    2422             
  Partials     213     213             
Impacted Files Coverage Δ
sdk/metric/pipeline.go 91.3% <ø> (-0.1%) ⬇️
sdk/trace/batch_span_processor.go 81.1% <0.0%> (-0.9%) ⬇️
exporters/jaeger/jaeger.go 91.1% <0.0%> (+0.8%) ⬆️

@MrAlias MrAlias merged commit 88f6000 into open-telemetry:main Jan 20, 2023
@MrAlias MrAlias deleted the rm-produceKey branch January 20, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants