-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure RegisterCallback method #3587
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of accepting instruments to register the callback with as a slice, accept them as variadic arguments.
MrAlias
added
pkg:API
Related to an API package
area:metrics
Part of OpenTelemetry Metrics
labels
Jan 11, 2023
MrAlias
requested review from
jmacd,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
January 11, 2023 20:52
jmacd
approved these changes
Jan 11, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3587 +/- ##
=====================================
Coverage 78.9% 78.9%
=====================================
Files 170 170
Lines 12460 12460
=====================================
Hits 9836 9836
Misses 2415 2415
Partials 209 209
|
dashpole
approved these changes
Jan 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 This looks really nice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3519
The
RegisterCallback
method is updated for ergonomic reasons to the following.The instruments are now passed as variadic arguments. This avoids the boilerplate of having to wrap instruments at call-time with a
[]instrument.Asynchronous{...}
slice.